slice → splice while moving entry to the top #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
======================================
Coverage 96.2% 96.2%
======================================
Files 4 4
Lines 79 79
======================================
Hits 76 76
Misses 3 3
Continue to review full report at Codecov.
|
jimmytuc
approved these changes
Oct 21, 2018
|
I'm sorry just a wrong click to approve, pls dismiss it. Thanks |
|
@jimmytuc can you please explain why you want to dismiss? I can see the bug still present in a master branch. This is current version: var entries = [{key: 1, value: 1}, {key: 2, value: 2}, {key: 3, value: 3}]
var key = 2
var cacheIndex = 1
var entry = entries[cacheIndex]
entries.slice(cacheIndex, 1)
entries.unshift(entry)
console.log(entries)
// [{key: 2, value: 2}, {key: 1, value: 1}, {key: 2, value: 2}, {key: 3, value: 3}]This is a fixed one: var entries = [{key: 1, value: 1}, {key: 2, value: 2}, {key: 3, value: 3}]
var key = 2
var cacheIndex = 1
var entry = entries[cacheIndex]
entries.splice(cacheIndex, 1)
entries.unshift(entry)
console.log(entries)
// [{key: 2, value: 2}, {key: 1, value: 1}, {key: 3, value: 3}] |
|
hi @heydiplo, you're right after I checked on this. Thanks |
|
Why hasn't this been merged? @erikras |
|
Wow. That's the worst kind of javascript typo. i.e. good interview question. 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's just a typo. We want an item to be removed at the old index and inserted at 0 on the next line.
splicedoes that,slicedoes nothing.